From 1c14a3e79fe8672dc2a3f563603ca8659d57f15b Mon Sep 17 00:00:00 2001
From: Alex Reisner <alex@alexreisner.com>
Date: Wed, 15 Sep 2010 00:36:26 -0400
Subject: [PATCH] Never fetch XML if search query is blank.
We were checking for a blank query in fetch_coordinates, now we do it in
_fetch_xml.
---
lib/geocoder.rb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/geocoder.rb b/lib/geocoder.rb
index 6d1fb60e..d3578260 100644
--- a/lib/geocoder.rb
+++ b/lib/geocoder.rb
@@ -323,7 +323,6 @@ module Geocoder
# Returns array [lat,lon] if found, nil if not found or if network error.
#
def self.fetch_coordinates(query)
- return nil if query.blank?
return nil unless doc = self.search(query)
# make sure search found a result
@@ -342,6 +341,7 @@ module Geocoder
# This method is not intended for general use (prefer Geocoder.search).
#
def self._fetch_xml(query)
+ return nil if query.blank?
params = {
:address => query,
:sensor => "false"
--
GitLab