From 722c22786c752af4564c63c48245aded05fbe623 Mon Sep 17 00:00:00 2001
From: Jeffects <jeffreyleung@alumni.calpoly.edu>
Date: Wed, 1 Jun 2016 16:32:35 -0700
Subject: [PATCH] Change SmartyStreets Zipcode API
SmartyStreets is permanently changing their ZIP Code API endpoint by
June 22 at 9am Mountain Time. The legacy API endpoint is available
until the 22nd.
This change basically changes the API endpoint and updated the tests to
reflect the change.
---
lib/geocoder/lookups/smarty_streets.rb | 7 +++++--
test/unit/lookups/smarty_streets_test.rb | 4 ++--
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/lib/geocoder/lookups/smarty_streets.rb b/lib/geocoder/lookups/smarty_streets.rb
index 92065d61..fa72318c 100644
--- a/lib/geocoder/lookups/smarty_streets.rb
+++ b/lib/geocoder/lookups/smarty_streets.rb
@@ -12,8 +12,11 @@ module Geocoder::Lookup
end
def query_url(query)
- path = zipcode_only?(query) ? "zipcode" : "street-address"
- "#{protocol}://api.smartystreets.com/#{path}?#{url_query_string(query)}"
+ if zipcode_only?(query)
+ "#{protocol}://us-zipcode.api.smartystreets.com/lookup?#{url_query_string(query)}"
+ else
+ "#{protocol}://api.smartystreets.com/street-address?#{url_query_string(query)}"
+ end
end
# required by API as of 26 March 2015
diff --git a/test/unit/lookups/smarty_streets_test.rb b/test/unit/lookups/smarty_streets_test.rb
index 04e19c43..710efc46 100644
--- a/test/unit/lookups/smarty_streets_test.rb
+++ b/test/unit/lookups/smarty_streets_test.rb
@@ -21,12 +21,12 @@ class SmartyStreetsTest < GeocoderTestCase
def test_query_for_zipcode_geocode
query = Geocoder::Query.new("22204")
- assert_match(/api\.smartystreets\.com\/zipcode\?/, query.url)
+ assert_match(/us-zipcode\.api\.smartystreets\.com\/lookup\?/, query.url)
end
def test_query_for_zipfour_geocode
query = Geocoder::Query.new("22204-1603")
- assert_match(/api\.smartystreets\.com\/zipcode\?/, query.url)
+ assert_match(/us-zipcode\.api\.smartystreets\.com\/lookup\?/, query.url)
end
def test_smarty_streets_result_components
--
GitLab