From 7aa17373a05c26000d096b8f3635798ab61a93cd Mon Sep 17 00:00:00 2001
From: Alex Reisner <alex@alexreisner.com>
Date: Wed, 30 Mar 2016 13:52:36 -0400
Subject: [PATCH] Fix "ambiguous first argument" warnings.
---
test/unit/logger_test.rb | 4 ++--
test/unit/lookups/geocodio_test.rb | 2 +-
test/unit/lookups/geoip2_test.rb | 2 +-
test/unit/lookups/google_test.rb | 2 +-
test/unit/lookups/ipinfo_io_test.rb | 4 ++--
test/unit/lookups/latlon_test.rb | 2 +-
test/unit/lookups/maxmind_geoip2_test.rb | 4 ++--
test/unit/lookups/maxmind_local_test.rb | 4 ++--
test/unit/lookups/opencagedata_test.rb | 4 ++--
test/unit/lookups/smarty_streets_test.rb | 8 ++++----
10 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/test/unit/logger_test.rb b/test/unit/logger_test.rb
index 01efefa1..c018ee12 100644
--- a/test/unit/logger_test.rb
+++ b/test/unit/logger_test.rb
@@ -18,7 +18,7 @@ class LoggerTest < GeocoderTestCase
def test_set_logger_logs
assert_equal nil, Geocoder.log(:warn, "should log")
- assert_match /should log\n$/, @tempfile.read
+ assert_match(/should log\n$/, @tempfile.read)
end
def test_logger_does_not_log_severity_too_low
@@ -30,7 +30,7 @@ class LoggerTest < GeocoderTestCase
def test_logger_logs_when_severity_high_enough
@logger.level = Logger::DEBUG
Geocoder.log(:warn, "important: should log!")
- assert_match /important: should log/, @tempfile.read
+ assert_match(/important: should log/, @tempfile.read)
end
def test_kernel_logger_does_not_log_severity_too_low
diff --git a/test/unit/lookups/geocodio_test.rb b/test/unit/lookups/geocodio_test.rb
index 43e44f4b..6b316be9 100644
--- a/test/unit/lookups/geocodio_test.rb
+++ b/test/unit/lookups/geocodio_test.rb
@@ -29,7 +29,7 @@ class GeocodioTest < GeocoderTestCase
def test_geocodio_reverse_url
query = Geocoder::Query.new([45.423733, -75.676333])
- assert_match /reverse/, query.url
+ assert_match(/reverse/, query.url)
end
def test_raises_invalid_request_exception
diff --git a/test/unit/lookups/geoip2_test.rb b/test/unit/lookups/geoip2_test.rb
index 46f2b476..d50e3bce 100644
--- a/test/unit/lookups/geoip2_test.rb
+++ b/test/unit/lookups/geoip2_test.rb
@@ -20,7 +20,7 @@ class Geoip2Test < GeocoderTestCase
assert_equal 'US', result.country_code
assert_equal '94043', result.postal_code
assert_equal 37.41919999999999, result.latitude
- assert_equal -122.0574, result.longitude
+ assert_equal(-122.0574, result.longitude)
assert_equal [37.41919999999999, -122.0574], result.coordinates
end
diff --git a/test/unit/lookups/google_test.rb b/test/unit/lookups/google_test.rb
index 867508e1..d658a827 100644
--- a/test/unit/lookups/google_test.rb
+++ b/test/unit/lookups/google_test.rb
@@ -89,6 +89,6 @@ class GoogleTest < GeocoderTestCase
def test_google_uses_https_when_api_key_is_set
Geocoder.configure(api_key: "deadbeef")
query = Geocoder::Query.new("Madison Square Garden, New York, NY")
- assert_match /^https:/, query.url
+ assert_match(/^https:/, query.url)
end
end
diff --git a/test/unit/lookups/ipinfo_io_test.rb b/test/unit/lookups/ipinfo_io_test.rb
index 4c3eccde..379f3838 100644
--- a/test/unit/lookups/ipinfo_io_test.rb
+++ b/test/unit/lookups/ipinfo_io_test.rb
@@ -6,12 +6,12 @@ class IpinfoIoTest < GeocoderTestCase
def test_ipinfo_io_use_http_without_token
Geocoder.configure(:ip_lookup => :ipinfo_io, :use_https => true)
query = Geocoder::Query.new("8.8.8.8")
- assert_match /^http:/, query.url
+ assert_match(/^http:/, query.url)
end
def test_ipinfo_io_uses_https_when_auth_token_set
Geocoder.configure(:ip_lookup => :ipinfo_io, :api_key => "FOO_BAR_TOKEN", :use_https => true)
query = Geocoder::Query.new("8.8.8.8")
- assert_match /^https:/, query.url
+ assert_match(/^https:/, query.url)
end
end
diff --git a/test/unit/lookups/latlon_test.rb b/test/unit/lookups/latlon_test.rb
index 2dcb47a9..49ca6642 100644
--- a/test/unit/lookups/latlon_test.rb
+++ b/test/unit/lookups/latlon_test.rb
@@ -29,7 +29,7 @@ class LatlonTest < GeocoderTestCase
def test_latlon_reverse_url
query = Geocoder::Query.new([45.423733, -75.676333])
- assert_match /reverse_geocode/, query.url
+ assert_match(/reverse_geocode/, query.url)
end
def test_raises_api_key_exception
diff --git a/test/unit/lookups/maxmind_geoip2_test.rb b/test/unit/lookups/maxmind_geoip2_test.rb
index 35235cbc..a930a201 100644
--- a/test/unit/lookups/maxmind_geoip2_test.rb
+++ b/test/unit/lookups/maxmind_geoip2_test.rb
@@ -15,8 +15,8 @@ class MaxmindGeoip2Test < GeocoderTestCase
assert_equal 'United States', result.country
assert_equal 'US', result.country_code
assert_equal '90001', result.postal_code
- assert_equal 37.6293, result.latitude
- assert_equal -122.1163, result.longitude
+ assert_equal(37.6293, result.latitude)
+ assert_equal(-122.1163, result.longitude)
assert_equal [37.6293, -122.1163], result.coordinates
end
diff --git a/test/unit/lookups/maxmind_local_test.rb b/test/unit/lookups/maxmind_local_test.rb
index b5bf847c..87b49481 100644
--- a/test/unit/lookups/maxmind_local_test.rb
+++ b/test/unit/lookups/maxmind_local_test.rb
@@ -15,8 +15,8 @@ class MaxmindLocalTest < GeocoderTestCase
assert_equal 'United States', result.country
assert_equal 'US', result.country_code
assert_equal '94043', result.postal_code
- assert_equal 37.41919999999999, result.latitude
- assert_equal -122.0574, result.longitude
+ assert_equal(37.41919999999999, result.latitude)
+ assert_equal(-122.0574, result.longitude)
assert_equal [37.41919999999999, -122.0574], result.coordinates
end
diff --git a/test/unit/lookups/opencagedata_test.rb b/test/unit/lookups/opencagedata_test.rb
index 3e838b65..496ec14a 100644
--- a/test/unit/lookups/opencagedata_test.rb
+++ b/test/unit/lookups/opencagedata_test.rb
@@ -11,7 +11,7 @@ class OpencagedataTest < GeocoderTestCase
def test_result_components
result = Geocoder.search("Madison Square Garden, New York, NY").first
assert_equal "West 31st Street", result.street
- assert_match /46, West 31st Street, Koreatown, New York County, 10011, New York City, New York, United States of America/, result.address
+ assert_match(/46, West 31st Street, Koreatown, New York County, 10011, New York City, New York, United States of America/, result.address)
end
@@ -39,7 +39,7 @@ class OpencagedataTest < GeocoderTestCase
def test_opencagedata_reverse_url
query = Geocoder::Query.new([45.423733, -75.676333])
- assert_match /\bq=45.423733%2C-75.676333\b/, query.url
+ assert_match(/\bq=45.423733%2C-75.676333\b/, query.url)
end
diff --git a/test/unit/lookups/smarty_streets_test.rb b/test/unit/lookups/smarty_streets_test.rb
index 7e999a6c..04e19c43 100644
--- a/test/unit/lookups/smarty_streets_test.rb
+++ b/test/unit/lookups/smarty_streets_test.rb
@@ -11,22 +11,22 @@ class SmartyStreetsTest < GeocoderTestCase
def test_url_contains_api_key
Geocoder.configure(:smarty_streets => {:api_key => 'blah'})
query = Geocoder::Query.new("Bluffton, SC")
- assert_match /auth-token=blah/, query.url
+ assert_match(/auth-token=blah/, query.url)
end
def test_query_for_address_geocode
query = Geocoder::Query.new("42 Wallaby Way Sydney, AU")
- assert_match /api\.smartystreets\.com\/street-address\?/, query.url
+ assert_match(/api\.smartystreets\.com\/street-address\?/, query.url)
end
def test_query_for_zipcode_geocode
query = Geocoder::Query.new("22204")
- assert_match /api\.smartystreets\.com\/zipcode\?/, query.url
+ assert_match(/api\.smartystreets\.com\/zipcode\?/, query.url)
end
def test_query_for_zipfour_geocode
query = Geocoder::Query.new("22204-1603")
- assert_match /api\.smartystreets\.com\/zipcode\?/, query.url
+ assert_match(/api\.smartystreets\.com\/zipcode\?/, query.url)
end
def test_smarty_streets_result_components
--
GitLab