From a25e3d7b8ef3dba9954a624b2441b7e018b5f111 Mon Sep 17 00:00:00 2001
From: Alex Reisner <alex@alexreisner.com>
Date: Wed, 29 Jan 2014 21:35:21 -0500
Subject: [PATCH] Add more useful/specific integration tests.

---
 .gitignore                           |  1 +
 test/integration/http_client_test.rb | 24 ++++++++++++++++++++++++
 test/integration/smoke_test.rb       | 26 --------------------------
 3 files changed, 25 insertions(+), 26 deletions(-)
 create mode 100644 test/integration/http_client_test.rb
 delete mode 100644 test/integration/smoke_test.rb

diff --git a/.gitignore b/.gitignore
index c94bfb4e..a199d36a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,3 +3,4 @@ rdoc/*
 *.gem
 .bundle
 Gemfile.lock
+api_keys.yml
diff --git a/test/integration/http_client_test.rb b/test/integration/http_client_test.rb
new file mode 100644
index 00000000..c024d59a
--- /dev/null
+++ b/test/integration/http_client_test.rb
@@ -0,0 +1,24 @@
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), *%w[ .. .. lib]))
+require 'pathname'
+require 'rubygems'
+require 'test/unit'
+require 'geocoder'
+require 'yaml'
+
+class HttpClientTest < Test::Unit::TestCase
+  def setup
+    @api_keys = YAML.load_file("api_keys.yml")
+  end
+
+  def test_http_basic_auth
+    Geocoder.configure(lookup: :geocoder_us, api_key: @api_keys["geocoder_us"])
+    results = Geocoder.search "27701"
+    assert_not_nil (r = results.first)
+  end
+
+  def test_ssl
+    Geocoder.configure(lookup: :esri, use_https: true)
+    results = Geocoder.search "27701"
+    assert_not_nil (r = results.first)
+  end
+end
diff --git a/test/integration/smoke_test.rb b/test/integration/smoke_test.rb
deleted file mode 100644
index 0b7cf2fb..00000000
--- a/test/integration/smoke_test.rb
+++ /dev/null
@@ -1,26 +0,0 @@
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), *%w[ .. .. lib]))
-require 'pathname'
-require 'rubygems'
-require 'test/unit'
-require 'geocoder'
-
-class SmokeTest < Test::Unit::TestCase
-
-  def test_simple_zip_code_search
-    result = Geocoder.search "27701"
-    assert_not_nil (r = result.first)
-    assert_equal "Durham", r.city
-    assert_equal "North Carolina", r.state
-  end
-
-  def test_simple_zip_code_search_with_ssl
-    Geocoder.configure(:use_https => true)
-    result = Geocoder.search "27701"
-    assert_not_nil (r = result.first)
-    assert_equal "Durham", r.city
-    assert_equal "North Carolina", r.state
-  ensure
-    Geocoder.configure(:use_https => false)
-  end
-
-end
-- 
GitLab