diff --git a/lib/geocoder/lookups/base.rb b/lib/geocoder/lookups/base.rb index 4b8027ec18afb6a6bc3aeb11d9ec7ce0d53db570..bc4703a275459b5501da5f43d7fc8a25d5c3969d 100644 --- a/lib/geocoder/lookups/base.rb +++ b/lib/geocoder/lookups/base.rb @@ -196,7 +196,7 @@ module Geocoder "http" + (configuration.use_https ? "s" : "") end - def valid_response(response) + def valid_response?(response) (200..399).include?(response.code.to_i) end @@ -212,7 +212,7 @@ module Geocoder check_api_key_configuration!(query) response = make_api_request(query) body = response.body - if cache and valid_response(response) + if cache and valid_response?(response) cache[key] = body end @cache_hit = false diff --git a/lib/geocoder/lookups/google.rb b/lib/geocoder/lookups/google.rb index 84c24a772823609a4e64ddf8f5f4eafc6e1d7813..337e31349432694fa17a342812552b8d34dd0f9a 100644 --- a/lib/geocoder/lookups/google.rb +++ b/lib/geocoder/lookups/google.rb @@ -16,7 +16,7 @@ module Geocoder::Lookup "#{protocol}://maps.googleapis.com/maps/api/geocode/json?" + url_query_string(query) end - def valid_response(response) + def valid_response?(response) status = parse_json(response.body)["status"] super(response) and ['OK', 'ZERO_RESULTS'].include?(status) end