From b0324d2e2188c6f0146a42cfeb08bc3335b71341 Mon Sep 17 00:00:00 2001
From: Alex Reisner <alex@alexreisner.com>
Date: Fri, 30 Aug 2013 08:33:41 -0700
Subject: [PATCH] Rename method (Ruby convention, returns boolean).
---
lib/geocoder/lookups/base.rb | 4 ++--
lib/geocoder/lookups/google.rb | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/geocoder/lookups/base.rb b/lib/geocoder/lookups/base.rb
index 4b8027ec..bc4703a2 100644
--- a/lib/geocoder/lookups/base.rb
+++ b/lib/geocoder/lookups/base.rb
@@ -196,7 +196,7 @@ module Geocoder
"http" + (configuration.use_https ? "s" : "")
end
- def valid_response(response)
+ def valid_response?(response)
(200..399).include?(response.code.to_i)
end
@@ -212,7 +212,7 @@ module Geocoder
check_api_key_configuration!(query)
response = make_api_request(query)
body = response.body
- if cache and valid_response(response)
+ if cache and valid_response?(response)
cache[key] = body
end
@cache_hit = false
diff --git a/lib/geocoder/lookups/google.rb b/lib/geocoder/lookups/google.rb
index 84c24a77..337e3134 100644
--- a/lib/geocoder/lookups/google.rb
+++ b/lib/geocoder/lookups/google.rb
@@ -16,7 +16,7 @@ module Geocoder::Lookup
"#{protocol}://maps.googleapis.com/maps/api/geocode/json?" + url_query_string(query)
end
- def valid_response(response)
+ def valid_response?(response)
status = parse_json(response.body)["status"]
super(response) and ['OK', 'ZERO_RESULTS'].include?(status)
end
--
GitLab