From f735a8bcec455bbb0cc24221091105c3df0bb4fb Mon Sep 17 00:00:00 2001
From: Huiming Teo <teohuiming@gmail.com>
Date: Mon, 5 Sep 2016 14:41:21 +0800
Subject: [PATCH] Fix incorrect extra attribute names in ipinfo_io result
---
lib/geocoder/results/ipinfo_io.rb | 4 ++--
test/unit/lookups/ipinfo_io_test.rb | 8 ++++++++
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/lib/geocoder/results/ipinfo_io.rb b/lib/geocoder/results/ipinfo_io.rb
index e588fa8e..25f9f924 100644
--- a/lib/geocoder/results/ipinfo_io.rb
+++ b/lib/geocoder/results/ipinfo_io.rb
@@ -8,7 +8,7 @@ module Geocoder::Result
end
def coordinates
- @data['loc'].split(",").map(&:to_f)
+ @data['loc'].to_s.split(",").map(&:to_f)
end
def city
@@ -36,7 +36,7 @@ module Geocoder::Result
end
def self.response_attributes
- %w['ip', 'region', 'postal']
+ %w(ip region postal)
end
response_attributes.each do |a|
diff --git a/test/unit/lookups/ipinfo_io_test.rb b/test/unit/lookups/ipinfo_io_test.rb
index 60b3ca31..a66093ce 100644
--- a/test/unit/lookups/ipinfo_io_test.rb
+++ b/test/unit/lookups/ipinfo_io_test.rb
@@ -22,4 +22,12 @@ class IpinfoIoTest < GeocoderTestCase
assert_equal 0.0, result.latitude
assert_equal "127.0.0.1", result.ip
end
+
+ def test_ipinfo_io_extra_attributes
+ Geocoder.configure(:ip_lookup => :ipinfo_io, :use_https => true)
+ result = Geocoder.search("8.8.8.8").first
+ assert_equal "8.8.8.8", result.ip
+ assert_equal "California", result.region
+ assert_equal "94040", result.postal
+ end
end
--
GitLab