Change-Id: I5a5ebe72a2080e3d30ce103f6c1caa1addd6557a

Change-Id: Ie91eac3da51f4c26af04d69dfc124d195de84ebe

Depending on which aspect we will consume, these can be either type.

Signed-off-by: Chris Forbes <chrisforbes@google.com>

Some VkFormats can be consumed as multiple types -- specifically,
depth/stencil is either float or uint, depending on which aspect we
consume.

Convert to bitfield, and require intersection rather than equality.
While we're at it, drop out some weird special-casing for unknown
component types-- this is left over from when shader validation was much
less complete.

Signed-off-by: Chris Forbes <chrisforbes@google.com>

Change-Id: I9f4723c0a61ef269919b44cc9ca557085ce760d7

Exact same if check performed multiple times.
Removing redundant one

Change-Id: Iff32a724e58a06b4a967ba2632e60cc5b4050238

Fixed an error in RenderPassInUseDestroyedSignaled that was causing
a benign failure on most devices but throwing an exception on Intel
Windows driver.

Change-Id: I985429e1bf20f68710faf2012a201a18b4648939

Simplified source and consolidated usage.

Change-Id: I662a94381f3b6119978a53308dc616e942259941

Addresses  GH #1048

Change-Id: Ie94796bcd13dc506e1b97c483763df9023567ac6

Change-Id: I5917fb3fe0360e51cf88196bf5f7d0fe118940b9

Add object to wrap VkCommandPool handle in testing framework.  Tests can
now create a custom command pool that works with the VkCommandBufferObj
wrapper.  Add utility function to VkDeviceObj that finds a queue family which
doesn't support a given capability.

Change-Id: I2f005249cc8650acf632f83ae5171de1b4509c8c

Split validation of command pool queue flag checks into a dedicated
function and add valid usage error enums.

Change-Id: I4fc4e71d96b818c281ad310dd0d15bca508efb94

CodeGen ignored these APIs as they contain handles which are embedded
in a structure and aliased. Added manual coverage.

Change-Id: I81cf1945981a8e0b69966a9d0e190e49ff728ea8

Also fixed up validation tests to handle message formatting changes.

Change-Id: I8671ae531d473bebdc034c33edcd9617ab96b836

Also changed all object handle zero casts to use TYPE_UNKNOWN.

Change-Id: I212fd9dd50a25dec98d1fbf46caa73401450c89f

Also updated some C-style casts and added TYPE_UNKNOWN where
appropriate.

Change-Id: Ia9c1d013dd73c4f6785df6151ee71715e310187b

This allows non-cmake platforms to compile the loader. Use a define
named VULKAN_NON_CMAKE_BUILD to disable CMAKE-specific features.

Change-Id: I6f6d8731fe1be60fd138e9fe1006c913fb029b47

IMAGE_STATE/BUFFER_STATE classes did not make deep copies of the
createinfo.pQueueFamilyIndices array, which could cause invalid
warnings to be reported to the user.

Change-Id: I7ebda777de9decb0c532a4999f78573460197fd7

In a few places, we were using VK_USE_PLATFORM_WIN32_KHR instead of
VK_USE_PLATFORM_WIN32_KHX.

Change-Id: I579ea848868396b9c2877e43ca24780476e55919

VerifyImageLayout had a side effect of setting image layout state if
the layout had not been seen by the cmd buffer. This update moves the
code to set the layout outside of the verify function and instead puts
it into new SetLayout* functions that are now called in the appropriate
PreCallRecord* functions.

Note that the previous behavior caused a side effect where layouts
could be updated even when the call down the chain did not occur.
The updated behavior will always update the layout to what is passed
as the explicit layout for any image copy operations whenever the
call down the chain is made. This is desirable b/c if the layout
didn't match the app saw the error during the Validate* portion of
the call and if they chose to ignore it then validation should
reflect the layout state of the image that was set by the call.

Since the side effect mentioned above is no longer present, this change
includes an update to InvalidImageLayout test where a second call to
vkCmdCopyImage() is made in order to actually transition the initial
image layout state so that expected errors are correct going fwd.

Modify the expected error strings based on refactor.

VerifySourceImageLayout() and VerifyDestImageLayout() were nearly
identical so I generalized a couple of pieces and combined them in the
single VerifyImageLayout() function.

- updated include/vulkan/vulkan.h
- updated scripts/generator.py
- updated scripts/vk.xml
- updated layers json files
- updated tests json files
- updated include/vulkan/vulkan.hpp

Change-Id: I1d18921f75ec74484918be6cfdba394fc397d2f5

Add vkGetPhysicalDeviceQueueFamilyProperties2KHR as an alternate way get
queue family count.

Change-Id: Ie0efee916a1bf091eb34c8610eec3c73943db846

Change-Id: Id4063c82d9e592f982c59fb12c6d9f06a9e7b35a

Don't assume format is supported. Check it before use.

Change-Id: Ic74e0fa98612497e57b8264e2c1e025c0b9bd807

The loader test build needed the appropriate #include defined
for more than just Windows platforms.

Change-Id: I434ba15586915cab4ce3784ca19a6a6f8f1f129a

Change-Id: I09259f443c6268753fb2c46e77d725e204efc142

Fix issue brought up by Masaki Takano in LunarXchange.

Change-Id: Ib6caa931decf5976e96bcd4629602b7f25b88001

Change-Id: I9dc470fb5c4668760a3164242779705d6f4c8f22

If bindInfoCount was 0 fence was not properly retired.

Change-Id: I2b6af38b0181d328eaf1bab2c2109f3492905aa0

Change-Id: Id03f32f636cef14cb6d549d7c04b05cd5c814d52

Signed-off-by: Chris Forbes <chrisforbes@google.com>

I know I'd done a bunch of work to reduce the dependency on layer_data
here before, but capability checking needs more broad access when
extensions gate capabilities. Adding yet another crazy parameter to the
intermediate functions just to avoid using layer_data here is silly.

Just plumb it all back through...

Signed-off-by: Chris Forbes <chrisforbes@google.com>

We need to know this in order to determine whether the corresponding
shader capability is acceptable.

Signed-off-by: Chris Forbes <chrisforbes@google.com>

Change-Id: I392aba1398381205728aead48d6cfd10aa47ac90

Added 2 VU checks for aspectMask on image copy. Added
test CopyImageAspectMismatch to provoke these VUs, and
a handful of other aspect mask VUs previously done but
missing tests.

Change-Id: Ib9c3eb9d95a9295ec485bb14b4221d4198fa6904

Added check for valid usage 01185.  Added test
CopyImageSampleCountMismatch() to verify the check.

Change-Id: I51e76e0334bd4f1c0fe564f241646fc8b788da1e

Fixes #1582

Change-Id: I2f06a7016643f61d7e6341df20f355cb510350ab

Add loader tests to evaluate the results returned by the new
vkEnumeratePhysicalDeviceGroupsKHX extension.

Change-Id: Ia5cf10d283be015080d48bb9e9bc4e84bf3b45b9