Skip to content
Snippets Groups Projects
Commit 3723b7fa authored by Alex Reisner's avatar Alex Reisner
Browse files

Don't rescue from StandardError on bad result.

This was causing unintended resuce from other exceptions like:
Errno::ECONNREFUSED: Connection refused - Unable to connect to Redis...
parent 79332799
No related branches found
No related tags found
No related merge requests found
...@@ -21,12 +21,8 @@ module Geocoder::Lookup ...@@ -21,12 +21,8 @@ module Geocoder::Lookup
def results(query) def results(query)
# don't look up a loopback address, just return the stored result # don't look up a loopback address, just return the stored result
return [reserved_result(query.text)] if query.loopback_ip_address? return [reserved_result(query.text)] if query.loopback_ip_address?
begin # note: Freegeoip.net returns plain text "Not Found" on bad request
return (doc = fetch_data(query)) ? [doc] : [] (doc = fetch_data(query)) ? [doc] : []
rescue StandardError => err # Freegeoip.net returns HTML on bad request
raise_error(err)
return []
end
end end
def reserved_result(ip) def reserved_result(ip)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment