Proper error handling

Remove silly check for HTML tags Add test case for invalid json

Proper error handling
Remove silly check for HTML tags Add test case for invalid json
3cfd2a20 · Robert Schaefer · 9e374887 · 3cfd2a20 · 3cfd2a20 · 3cfd2a20
Unverified Commit 3cfd2a20 authored 7 years ago by Robert Schaefer
--- a/lib/geocoder/lookups/ipdata_co.rb
+++ b/lib/geocoder/lookups/ipdata_co.rb
@@ -18,10 +18,6 @@ module Geocoder::Lookup
    private # ---------------------------------------------------------------
-    def parse_raw_data(raw_data)
-      raw_data.match(/^<html><title>404/) ? nil : super(raw_data)
-    end
    def results(query)
      # don't look up a loopback address, just return the stored result
      return [reserved_result(query.text)] if query.loopback_ip_address?

--- a/test/fixtures/ipdata_co_8_8_8
+++ b/test/fixtures/ipdata_co_8_8_8
+8.8.8 does not appear to be an IPv4 or IPv6 address
\ No newline at end of file
--- a/test/unit/lookups/ipdata_co_test.rb
+++ b/test/unit/lookups/ipdata_co_test.rb
@@ -12,8 +12,16 @@ class IpdataCoTest < GeocoderTestCase
    assert result.is_a?(Geocoder::Result::IpdataCo)
  end
+  def test_invalid_json
+    Geocoder.configure(:always_raise => [Geocoder::ResponseParseError])
+    assert_raise Geocoder::ResponseParseError do
+      Geocoder.search("8.8.8", ip_address: true)
+    end
+  end
  def test_result_components
    result = Geocoder.search("74.200.247.59").first
    assert_equal "Jersey City, NJ 07302, United States", result.address
  end
 end