Merge pull request #843 from TrangPham/silence-warnings

Silence warnings using silence_warnings blocks

test/unit/logger_test.rb

@@ -40,6 +40,8 @@ class LoggerTest < GeocoderTestCase
 
   def test_kernel_logger_always_returns_nil
     Geocoder.configure(logger: :kernel)
-    assert_equal nil, Geocoder.log(:info, "should log")
+    silence_warnings do
+      assert_equal nil, Geocoder.log(:warn, "should log")
+    end
   end
 end

test/unit/lookup_test.rb

@@ -12,11 +12,13 @@ class LookupTest < GeocoderTestCase
   end
 
   def test_search_returns_empty_array_when_no_results
-    Geocoder::Lookup.all_services_except_test.each do |l|
-      lookup = Geocoder::Lookup.get(l)
-      set_api_key!(l)
-      assert_equal [], lookup.send(:results, Geocoder::Query.new("no results")),
-        "Lookup #{l} does not return empty array when no results."
+    silence_warnings do
+      Geocoder::Lookup.all_services_except_test.each do |l|
+        lookup = Geocoder::Lookup.get(l)
+        set_api_key!(l)
+        assert_equal [], lookup.send(:results, Geocoder::Query.new("no results")),
+          "Lookup #{l} does not return empty array when no results."
+      end
     end
   end
 

test/unit/lookups/google_places_details_test.rb

@@ -90,7 +90,9 @@ class GooglePlacesDetailsTest < GeocoderTestCase
   end
 
   def test_google_places_details_result_with_invalid_place_id_empty
-    assert_equal Geocoder.search("invalid request"), []
+    silence_warnings do
+      assert_equal Geocoder.search("invalid request"), []
+    end
   end
 
   def test_raises_exception_on_google_places_details_invalid_request

test/unit/lookups/pointpin_test.rb

@@ -18,12 +18,16 @@ class PointpinTest < GeocoderTestCase
   end
 
   def test_no_results
-    results = Geocoder.search("10.10.10.10")
-    assert_equal 0, results.length
+    silence_warnings do
+      results = Geocoder.search("10.10.10.10")
+      assert_equal 0, results.length
+    end
   end
 
   def test_invalid_address
-    results = Geocoder.search("555.555.555.555", ip_address: true)
-    assert_equal 0, results.length
+    silence_warnings do
+      results = Geocoder.search("555.555.555.555", ip_address: true)
+      assert_equal 0, results.length
+    end
   end
 end