Skip to content
Snippets Groups Projects
Commit 54b45d10 authored by Alex Reisner's avatar Alex Reisner
Browse files

Merge branch 'pr/889'

Conflicts:
	lib/geocoder/lookups/base.rb
parents c4c2d3c5 8b76c452
No related branches found
No related tags found
No related merge requests found
...@@ -29,4 +29,7 @@ module Geocoder ...@@ -29,4 +29,7 @@ module Geocoder
class ServiceUnavailable < Error class ServiceUnavailable < Error
end end
class LookupTimeout < ::Timeout::Error
end
end end
...@@ -271,20 +271,20 @@ module Geocoder ...@@ -271,20 +271,20 @@ module Geocoder
# return the response object. # return the response object.
# #
def make_api_request(query) def make_api_request(query)
timeout(configuration.timeout) do uri = URI.parse(query_url(query))
uri = URI.parse(query_url(query)) Geocoder.log(:debug, "Geocoder: HTTP request being made for #{uri.to_s}")
Geocoder.log(:debug, "Geocoder: HTTP request being made for #{uri.to_s}") http_client.start(uri.host, uri.port, use_ssl: use_ssl?, open_timeout: configuration.timeout, read_timeout: configuration.timeout) do |client|
http_client.start(uri.host, uri.port, use_ssl: use_ssl?) do |client| req = Net::HTTP::Get.new(uri.request_uri, configuration.http_headers)
req = Net::HTTP::Get.new(uri.request_uri, configuration.http_headers) if configuration.basic_auth[:user] and configuration.basic_auth[:password]
if configuration.basic_auth[:user] and configuration.basic_auth[:password] req.basic_auth(
req.basic_auth( configuration.basic_auth[:user],
configuration.basic_auth[:user], configuration.basic_auth[:password]
configuration.basic_auth[:password] )
)
end
client.request(req)
end end
client.request(req)
end end
rescue Net::OpenTimeout, Net::ReadTimeout
raise Geocoder::LookupTimeout
end end
def use_ssl? def use_ssl?
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment