Skip to content
Snippets Groups Projects
Commit 83a3cb5c authored by Andrew Kane's avatar Andrew Kane
Browse files

Safer timeouts

parent 350567f5
No related branches found
No related tags found
No related merge requests found
...@@ -263,18 +263,16 @@ module Geocoder ...@@ -263,18 +263,16 @@ module Geocoder
# return the response object. # return the response object.
# #
def make_api_request(query) def make_api_request(query)
timeout(configuration.timeout) do uri = URI.parse(query_url(query))
uri = URI.parse(query_url(query)) http_client.start(uri.host, uri.port, use_ssl: use_ssl?, open_timeout: configuration.timeout, read_timeout: configuration.timeout) do |client|
http_client.start(uri.host, uri.port, use_ssl: use_ssl?) do |client| req = Net::HTTP::Get.new(uri.request_uri, configuration.http_headers)
req = Net::HTTP::Get.new(uri.request_uri, configuration.http_headers) if configuration.basic_auth[:user] and configuration.basic_auth[:password]
if configuration.basic_auth[:user] and configuration.basic_auth[:password] req.basic_auth(
req.basic_auth( configuration.basic_auth[:user],
configuration.basic_auth[:user], configuration.basic_auth[:password]
configuration.basic_auth[:password] )
)
end
client.request(req)
end end
client.request(req)
end end
end end
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment