Skip to content
Snippets Groups Projects
Commit df0aaa6c authored by Alex Reisner's avatar Alex Reisner
Browse files

Merge pull request #1033 from hanloong/master

Add result_type as option for google lookup
parents 46571560 f5c7fc03
No related branches found
No related tags found
No related merge requests found
......@@ -65,6 +65,9 @@ module Geocoder::Lookup
unless (components = query.options[:components]).nil?
params[:components] = components.is_a?(Array) ? components.join("|") : components
end
unless (result_type = query.options[:result_type]).nil?
params[:result_type] = result_type.is_a?(Array) ? result_type.join("|") : result_type
end
params
end
......
......@@ -86,6 +86,26 @@ class GoogleTest < GeocoderTestCase
assert url.include?(formatted), "Expected #{formatted} to be included in #{url}"
end
def test_google_query_url_contains_result_type_when_given_as_string
lookup = Geocoder::Lookup::Google.new
url = lookup.query_url(Geocoder::Query.new(
"Some Intersection",
:result_type => "country"
))
formatted = "result_type=" + CGI.escape("country")
assert url.include?(formatted), "Expected #{formatted} to be included in #{url}"
end
def test_google_query_url_contains_result_type_when_given_as_array
lookup = Geocoder::Lookup::Google.new
url = lookup.query_url(Geocoder::Query.new(
"Some Intersection",
:result_type => ["country", "postal_code"]
))
formatted = "result_type=" + CGI.escape("country|postal_code")
assert url.include?(formatted), "Expected #{formatted} to be included in #{url}"
end
def test_google_uses_https_when_api_key_is_set
Geocoder.configure(api_key: "deadbeef")
query = Geocoder::Query.new("Madison Square Garden, New York, NY")
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment