Skip to content
Snippets Groups Projects
Commit e2285a13 authored by Alex Reisner's avatar Alex Reisner Committed by GitHub
Browse files

Merge pull request #1153 from RoyLee/fix_smarty_sheets_nil_results_for_some_zip_codes

Update smarty streets search results coordinates method to return nil 
parents 54d9d621 31571cd8
No related branches found
No related tags found
No related merge requests found
...@@ -3,9 +3,15 @@ require 'geocoder/lookups/base' ...@@ -3,9 +3,15 @@ require 'geocoder/lookups/base'
module Geocoder::Result module Geocoder::Result
class SmartyStreets < Base class SmartyStreets < Base
def coordinates def coordinates
%w(latitude longitude).map do |i| result = %w(latitude longitude).map do |i|
zipcode_endpoint? ? zipcodes.first[i] : metadata[i] zipcode_endpoint? ? zipcodes.first[i] : metadata[i]
end end
if result.compact.empty?
nil
else
result
end
end end
def address def address
......
[{"input_index":0,"city_states":[{"city":"FPO","state_abbreviation":"AP","state":"ArmedForcesPacific","mailable_city":true}],"zipcodes":[{"zipcode":"96628","zipcode_type":"M","default_city":"Fpo","county_fips":"00000","county_name":"None","state_abbreviation":"AP","state":"ArmedForcesPacific","precision":"None"}]}]
...@@ -47,6 +47,11 @@ class SmartyStreetsTest < GeocoderTestCase ...@@ -47,6 +47,11 @@ class SmartyStreetsTest < GeocoderTestCase
assert result.zipcode_endpoint? assert result.zipcode_endpoint?
end end
def test_smarty_streets_when_longitude_latitude_does_not_exist
result = Geocoder.search("96628").first
assert_equal nil, result.coordinates
end
def test_no_results def test_no_results
results = Geocoder.search("no results") results = Geocoder.search("no results")
assert_equal 0, results.length assert_equal 0, results.length
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment