Skip to content
Snippets Groups Projects
  1. Mar 21, 2015
  2. Jul 25, 2014
    • Brian McManus's avatar
      Allow lookup service to fully opt-out of https · e4ae5978
      Brian McManus authored
      If you have an address geocoding service that you want to use HTTPS with
      and then attempt to use an ip_geocoder that does not support HTTPS (e.g.
      Telize) then the ip_geocoder lookups will fail because
      Geocoder::Lookups::Base#make_api_request turns on opts[:use_ssl] based
      on that single configuration value.
      
      Rather than allowing for per-provider HTTPS configuration I have just
      refactored Geocoder::Lookups::Base call a private `use_ssl?` method
      which can be overridden by individual lookup provider implementations.
      The default implementation of `use_ssl?` simply returns the value from
      the config thus preserving the existing behavior but this allows
      subclasses, like Telize, to override `use_ssl?` completely to return
      false and thus fully opt-out of HTTPS regardless of what the
      configuration was.
      e4ae5978
  3. Feb 25, 2014
  4. Jan 30, 2014
  5. Dec 08, 2012
  6. Sep 02, 2012
  7. Sep 21, 2011
    • Rob Sanheim's avatar
      Make https support really work: · 5b8215a7
      Rob Sanheim authored
        - need to set `use_ssl` to true
        - also cannot use `get_response` class method for https requests
        - add a smoke_test that calls out to google for real, to make sure
          things work end to end (not using test_helper for this, because it's invasive
          and opens code under test to do it's mocking)
        - add smoke_test to default test run
      5b8215a7
Loading