Skip to content
Snippets Groups Projects
  1. Nov 30, 2016
    • Alex Reisner's avatar
      Remove debugging line. · aa5aba66
      Alex Reisner authored
      aa5aba66
    • Alex Reisner's avatar
      Avoid calling fetch_data within method. · 9d48fb85
      Alex Reisner authored
      9d48fb85
    • Julian Nacci's avatar
      Add new lookup: ban_data_gouv_fr · 4e9f1139
      Julian Nacci authored
      add new lookup to lookup.rb
      
      add new lookup file ban_data_gouv_fr.rb
      
      add new results file ban_data_gouv_fr.rb
      
      update README with new lookup
      
      create fixtures to test  new lookup
      
      create unit test file for new lookup
      
      update test helper default fixture for new lookup
      
      remove invalid multibyte char (US-ASCII) 'ç' from lookup name
      
      Revert "remove invalid multibyte char (US-ASCII) 'ç' from lookup name"
      
      This reverts commit 7dbfcab4dc4bcb9473edc43651e7d53884f0e24d.
      
      Add '# encoding: utf-8' to files containing special chars
      
      Add '# encoding: utf-8' to files containing special chars
      
      Add '# encoding: utf-8' to files containing special chars
      
      remove useless Geocoder.config from test methods
      
      refacto of ban lookup results method
      
      change city serach param to fit naming conventions in ban lookup test
      
      renamed no results ban lookup fixture to fit tests
      
      removed no search results unnecessary test
      
      remove useless commented code
      
      add alias method to handle state and state_code + move from department to region name as state
      
      refacto results method
      4e9f1139
  2. Nov 28, 2016
  3. Nov 15, 2016
  4. Nov 09, 2016
    • tunamonster's avatar
      Refactor calculations (#1116) · 1c306367
      tunamonster authored
      * Refactor calculations
      
      Refactored calculations::extract_coordinates and calculations::coordinates_present?
      
      coordinates_present?
      Checks whether an argument matches validating criteria (numeric, not NaN), rather than returning false when matching invalidating criteria.
      
      Also replaced .to_s == NaN with .to_f..nan? 
      
      extract_coordinates 
      Now calls coordinates_present? to validate the array, instead of comparing four booleans and initialising extra vars.
      
      * Removed .map and ternary from coordinates_present?
      
      Updated pull request according to Lime's suggestions.
      1c306367
  5. Oct 18, 2016
  6. Oct 08, 2016
  7. Sep 22, 2016
  8. Sep 21, 2016
  9. Sep 09, 2016
  10. Sep 08, 2016
  11. Sep 06, 2016
  12. Sep 05, 2016
  13. Aug 31, 2016
  14. Aug 25, 2016
  15. Aug 19, 2016
  16. Jul 27, 2016
    • Alex Reisner's avatar
      Merge pull request #1083 from pcantrell/patch-1 · 07980edd
      Alex Reisner authored
      Prevent rake task crash when BATCH not specified
      07980edd
    • Paul Cantrell's avatar
      Prevent rake task crash when BATCH not specified · 76bc7c63
      Paul Cantrell authored
      In Rails 5, `rake geocode:all` crashes:
      
      ```
      $ rake geocode:all CLASS=Whatzit
      rake aborted!
      ArgumentError: comparison of Fixnum with nil failed
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:217:in `<'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:217:in `block in in_batches'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:198:in `loop'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:198:in `in_batches'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:120:in `find_in_batches'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:58:in `find_each'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/geocoder-1.2.2/lib/tasks/geocoder.rake:11:in `block (2 levels) in <top (required)>'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/rake-11.2.2/exe/rake:27:in `<top (required)>'
      /Users/paul/.rvm/gems/ruby-2.2.2/bin/ruby_executable_hooks:15:in `eval'
      /Users/paul/.rvm/gems/ruby-2.2.2/bin/ruby_executable_hooks:15:in `<main>'
      Tasks: TOP => geocode:all
      (See full trace by running task with --trace)
      ```
      
      The problem seems to be that `find_each` used to default the `batch:` param when it was explicitly set to nil, but now passes an explicit nil on through.
      
      This patch fixes the issue by defaulting the batch size in the rake task.
      76bc7c63
Loading