- Nov 30, 2016
-
-
Alex Reisner authored
-
Alex Reisner authored
-
Julian Nacci authored
add new lookup to lookup.rb add new lookup file ban_data_gouv_fr.rb add new results file ban_data_gouv_fr.rb update README with new lookup create fixtures to test new lookup create unit test file for new lookup update test helper default fixture for new lookup remove invalid multibyte char (US-ASCII) 'ç' from lookup name Revert "remove invalid multibyte char (US-ASCII) 'ç' from lookup name" This reverts commit 7dbfcab4dc4bcb9473edc43651e7d53884f0e24d. Add '# encoding: utf-8' to files containing special chars Add '# encoding: utf-8' to files containing special chars Add '# encoding: utf-8' to files containing special chars remove useless Geocoder.config from test methods refacto of ban lookup results method change city serach param to fit naming conventions in ban lookup test renamed no results ban lookup fixture to fit tests removed no search results unnecessary test remove useless commented code add alias method to handle state and state_code + move from department to region name as state refacto results method
-
- Nov 28, 2016
-
-
Alex Reisner authored
-
Alex Reisner authored
-
Simon Stemplinger authored
support for opencagedata optional parameters
-
- Nov 15, 2016
- Nov 09, 2016
-
-
tunamonster authored
* Refactor calculations Refactored calculations::extract_coordinates and calculations::coordinates_present? coordinates_present? Checks whether an argument matches validating criteria (numeric, not NaN), rather than returning false when matching invalidating criteria. Also replaced .to_s == NaN with .to_f..nan? extract_coordinates Now calls coordinates_present? to validate the array, instead of comparing four booleans and initialising extra vars. * Removed .map and ternary from coordinates_present? Updated pull request according to Lime's suggestions.
-
- Oct 18, 2016
-
-
Alex Reisner authored
Update README.md
-
Jon McCartie authored
-
- Oct 08, 2016
-
-
Alex Reisner authored
[TYPO] Fixes a couple of typos in the README
-
Alex Brinkman authored
-
- Sep 22, 2016
-
-
Alex Reisner authored
Fix README regarding dstk :host configuration
-
Alex Reisner authored
Add Lookup::Test.reset to README
-
- Sep 21, 2016
-
-
Nathan Wenneker authored
The method `#reset` for clearing stubs was previously unmentioned in the README
-
Nathan Wenneker authored
:host must be nested within the :dstk key in order to be recognized.
-
- Sep 09, 2016
-
-
Alex Reisner authored
Added LocationIQ provider
-
aleem uddin authored
LocationIq # for classes location_iq # for config
-
- Sep 08, 2016
-
-
Alex Reisner authored
-
Alex Reisner authored
No escaping should be necessary, according to the MaxMind docs: http://dev.maxmind.com/geoip/geoip2/web-services/
-
Alex Reisner authored
Make geocoded? return false with single coordinate
-
- Sep 06, 2016
-
-
Alex Reisner authored
support canada for geocodio
-
Ryan Boland authored
-
Alex Reisner authored
Use sqlite ruby math extensions if present
-
Aleem Uddin authored
Add test coverage for LocationIQ lookup
-
- Sep 05, 2016
-
-
Ryan Boland authored
-
Ryan Boland authored
-
Alex Reisner authored
Fix result of ipinfo.io for loopback address (127.0.0.1)
-
toydi authored
-
toydi authored
-
- Aug 31, 2016
-
-
Greg Signal authored
-
- Aug 25, 2016
-
-
aleem uddin authored
-
- Aug 19, 2016
-
-
Will Jordan authored
-
- Jul 27, 2016
-
-
Alex Reisner authored
Prevent rake task crash when BATCH not specified
-
Paul Cantrell authored
In Rails 5, `rake geocode:all` crashes: ``` $ rake geocode:all CLASS=Whatzit rake aborted! ArgumentError: comparison of Fixnum with nil failed /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:217:in `<' /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:217:in `block in in_batches' /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:198:in `loop' /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:198:in `in_batches' /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:120:in `find_in_batches' /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:58:in `find_each' /Users/paul/.rvm/gems/ruby-2.2.2/gems/geocoder-1.2.2/lib/tasks/geocoder.rake:11:in `block (2 levels) in <top (required)>' /Users/paul/.rvm/gems/ruby-2.2.2/gems/rake-11.2.2/exe/rake:27:in `<top (required)>' /Users/paul/.rvm/gems/ruby-2.2.2/bin/ruby_executable_hooks:15:in `eval' /Users/paul/.rvm/gems/ruby-2.2.2/bin/ruby_executable_hooks:15:in `<main>' Tasks: TOP => geocode:all (See full trace by running task with --trace) ``` The problem seems to be that `find_each` used to default the `batch:` param when it was explicitly set to nil, but now passes an explicit nil on through. This patch fixes the issue by defaulting the batch size in the rake task.
-