Skip to content
Snippets Groups Projects
  1. Sep 09, 2016
  2. Sep 08, 2016
  3. Sep 06, 2016
  4. Sep 05, 2016
  5. Aug 31, 2016
  6. Aug 25, 2016
  7. Aug 19, 2016
  8. Jul 27, 2016
    • Paul Cantrell's avatar
      Prevent rake task crash when BATCH not specified · 76bc7c63
      Paul Cantrell authored
      In Rails 5, `rake geocode:all` crashes:
      
      ```
      $ rake geocode:all CLASS=Whatzit
      rake aborted!
      ArgumentError: comparison of Fixnum with nil failed
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:217:in `<'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:217:in `block in in_batches'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:198:in `loop'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:198:in `in_batches'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:120:in `find_in_batches'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:58:in `find_each'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/geocoder-1.2.2/lib/tasks/geocoder.rake:11:in `block (2 levels) in <top (required)>'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/rake-11.2.2/exe/rake:27:in `<top (required)>'
      /Users/paul/.rvm/gems/ruby-2.2.2/bin/ruby_executable_hooks:15:in `eval'
      /Users/paul/.rvm/gems/ruby-2.2.2/bin/ruby_executable_hooks:15:in `<main>'
      Tasks: TOP => geocode:all
      (See full trace by running task with --trace)
      ```
      
      The problem seems to be that `find_each` used to default the `batch:` param when it was explicitly set to nil, but now passes an explicit nil on through.
      
      This patch fixes the issue by defaulting the batch size in the rake task.
      76bc7c63
  9. Jun 27, 2016
  10. Jun 26, 2016
  11. Jun 09, 2016
  12. Jun 07, 2016
  13. Jun 02, 2016
    • Jeffects's avatar
      Change SmartyStreets Zipcode API · 722c2278
      Jeffects authored
      SmartyStreets is permanently changing their ZIP Code API endpoint by
      June 22 at 9am Mountain Time.  The legacy API endpoint is available
      until the 22nd.
      
      This change basically changes the API endpoint and updated the tests to
      reflect the change.
      722c2278
  14. May 31, 2016
  15. May 27, 2016
  16. May 26, 2016
  17. May 25, 2016
  18. May 24, 2016
  19. May 20, 2016
  20. May 17, 2016
  21. May 06, 2016
  22. May 02, 2016
  23. Apr 28, 2016
  24. Apr 17, 2016
  25. Apr 16, 2016
    • Piotr Górecki's avatar
      Use a proper domain name in ipapi_com lookup (#1020) · 162b5915
      Piotr Górecki authored
      * Add ip-api.com (ip lookup) support
      
      This service returns better coordinates for Europe than other free ip lookup services available in geocoder.
      
      * Clean the results class
      
      Remove default responses for fields.
      
      * Remove checking fields in url query
      
      API already handles unknown fields, so this check is unnecessary.
      
      * Add a test for using parameters directly in search method
      
      * Use proper domain name
      
      Use pro.ip-api.com domain in case when api key is in use, otherwise just ip-api.com.
      
      * Handle invalid api key
      
      * Add forsaken fixture
      
      * Make uniform an invalid key handler with the other geocoder lookups
      162b5915
Loading